How to properly terminate the nail?

facebookarchive / nailgun

Nailgun is a client, protocol, and server for running Java programs from the command line without incurring the JVM startup overhead.

https://github.com/facebook/nailgun

Other

731 stars 138 forks source link

How to properly terminate the nail? #133

Closed rrzaripov closed 6 years ago

rrzaripov commented 6 years ago

I'm runnning storescp tool from dcm4che project. This utility work as server - listen some port in infinite loop and interupted by pressing CTRL+C keys. But how shutdown it in nailgun? I'm trying to close transport, but nail still work. Sending CTRL+C via stdin also not work. Thank you in advance for any help.

sbalabanov-zz commented 6 years ago

Do you want to terminate the nail or nailgun (server)?

For nail, you subscribe nail's code to client's event with NGContext.addClientListener (example: https://github.com/facebook/buck/blob/dcbc69700809ac65519abf0ed34e58cf8e5b78f0/src/com/facebook/buck/cli/Main.java#L1332) and upon receiving a termination signal, handle it properly with nails' code, for example interrupting the running thread.
For nailgun, you just send ng-stop command

rrzaripov commented 6 years ago

I need terminate nail, so adding listener into nail code perhaps the best way to do it. Thank for code example!