search

facebookarchive / nailgun

Nailgun is a client, protocol, and server for running Java programs from the command line without incurring the JVM startup overhead.
https://github.com/facebook/nailgun
Other
731 stars 138 forks source link

Tidy up and bug fixes #185

Open aanno opened 4 years ago

aanno commented 4 years ago

Well, as I tried this, I stepped upon a few problems:

  1. Missing documentation, hence I updated the readme.
  2. A few missing @Override and @FunctionalInterface.
  3. Public attributes in NGContext, hence I added getter (the setter were already there).
  4. Problems with the Classloader stuff on Java ~8~ 11, hence it fixed that.
  5. mvn version not set to a SNAPSHOT
  6. A few missing flush().
  7. ng-version command not working in development setup.
  8. Some errors (like ClassNotFound) not propagated to client.

I decided to fix all that.

facebook-github-bot commented 4 years ago

Hi @aanno!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

v-jizhang commented 4 years ago

@aanno This PR should split into multiple ones. Could you do it? Thanks.

aanno commented 4 years ago

Ok, first round:

After these 3 are accepted, I will work on the rest.