facebookarchive / network-connection-class

Listen to current network traffic in the app and categorize the quality of the network.
Other
3.19k stars 515 forks source link

Bug 15 fix - 'Pull request' guideline formatting #16

Open PrashantSunkari opened 9 years ago

PrashantSunkari commented 9 years ago

Fixing the bug#15.

  1. Pull request guidelines points are now formatted in their own line
  2. Added a wiki link to indicate what lint roughly means in this context. Current guideline about lint is not appropriate for this java project.

    'lint' reference makes more sense for javascript project with grunt. Example: https://github.com/facebook/react/blob/master/CONTRIBUTING.md#pull-requests

PrashantSunkari commented 9 years ago

Sorry for multiple bugs. Didn't realize editing file on the github website with a pull request will create a new bug. My bad

klaraahmed commented 6 years ago