Diagnostics with 'Current file only' checked does not allow clicking to navigate to the relevant code

chrismcband commented 7 years ago

Issue and Steps to Reproduce

Open the Diagnostics, make sure 'Current file only' is checked, click in a text file, in my project this was a JSX file.

See the errors appear in the Diagnostics panel, click on one of the errors to go to that line. Observe the Diagnostics panel errors are cleared.

I suspect the Diagnostics panel is only displaying errors when the editor has focus, so trying to click an error within the panel is removing this focus and so the errors are cleared. When the 'Current file only' is unchecked the behaviour is correct, because the errors are no longer cleared.

Expected Behavior

Clicking the error should focus the editor and navigate to the related line.

Actual Behavior

Diagnostics panel is cleared of all errors and editor remains unaffected.

Versions

Atom: 1.17.2 x64
Nuclide: 0.229.0
Client OS: macOS Sierra 10.12.5
Server OS (optional):

Additional Details

Installed packages (apm ls --installed):

Community Packages (36) /Users/chris/.atom/packages
├── MagicPython@1.0.10
├── atom-html-preview@0.1.22
├── atom-pair@2.0.10
├── atom-tracker@0.3.3
├── git-diff-details@1.4.0
├── git-plus@7.9.2
├── git-time-machine@1.5.9
├── haskell-grammar@0.4.0
├── highlight-selected@0.13.1
├── language-babel@2.63.0
├── language-graphql@0.9.0
├── language-ini@1.19.0
├── language-lua@0.9.11
├── language-ocaml@1.9.2
├── language-rust@0.4.10
├── language-swift@0.5.0
├── language-thrift@1.0.2
├── line-diff-details@1.8.0
├── linter@2.1.4
├── linter-eslint@8.2.1
├── linter-scss-lint@3.1.0
├── markdown-preview-plus@2.4.9
├── merge-conflicts@1.4.5
├── nuclide@0.229.0
├── nuclide-format-js@0.0.36
├── pigments@0.39.1
├── platformio-ide-terminal@2.5.1
├── prettier-atom@0.31.1
├── redux-devtools@0.5.1
├── set-syntax@0.3.2
├── sort-lines@0.14.0
├── sync-settings@0.8.1
├── tool-bar@1.1.0
├── tree-view-git-status@1.4.0
├── vim-mode@0.66.0
└── vim-mode-plus@0.93.0

nahuelhds commented 7 years ago

Just in case: when disabling the nuclide-file-tree package and enabling tree-view (default's Atom) the "Current only" option works fine.

chrismcband commented 7 years ago

This must have recently been fixed. I'm no longer seeing this issue, here's my latest package list with Atom 1.18.0 x64:

├── MagicPython@1.0.10
├── aligner@1.2.3
├── aligner-javascript@1.2.0
├── aligner-python@1.1.0
├── atom-html-preview@0.1.22
├── atom-pair@2.0.12
├── atom-ternjs@0.18.3
├── atom-tracker@0.3.3
├── browser-plus@0.0.98
├── emmet@2.4.3
├── file-icons@2.1.9
├── git-diff-details@1.4.0
├── git-plus@7.9.3
├── git-time-machine@1.5.9
├── haskell-grammar@0.4.0
├── highlight-line@0.12.0
├── highlight-selected@0.13.1
├── javascript-snippets@1.2.1
├── jumpy@3.1.3
├── language-babel@2.67.0
├── language-graphql@0.9.0
├── language-ini@1.19.0
├── language-lua@0.9.11
├── language-ocaml@1.9.5
├── language-rust@0.4.11
├── language-swift@0.5.0
├── language-thrift@1.0.2
├── line-diff-details@1.8.0
├── linter@2.2.0
├── linter-eslint@8.2.1
├── linter-scss-lint@3.1.0
├── markdown-preview-plus@2.4.10
├── merge-conflicts@1.4.5
├── minimap@4.29.0
├── nuclide@0.240.0
├── nuclide-format-js@0.0.36
├── open-in-browser@0.5.2
├── pane-browser@1.6.0
├── pigments@0.39.1
├── platformio-ide-terminal@2.5.3
├── prettier-atom@0.36.1
├── redux-devtools@0.5.1
├── rest-client@1.3.1
├── set-syntax@0.3.2
├── seti-syntax@1.1.3
├── seti-ui@1.9.0
├── sort-lines@0.14.0
├── sync-settings@0.8.2
├── tool-bar@1.1.0
├── tree-view-git-status@1.4.0
├── vim-mode@0.66.0
├── vim-mode-plus@0.94.0
└── wakatime@7.0.3

facebookarchive / nuclide