File tree - Cannot use keyboard at all on any file inside pane

nahuelhds commented 7 years ago

Issue and Steps to Reproduce

Cannot use any keyboard key or shortcut for any file inside the file tree pane.

Expected Behavior

Use cases:

I wanna copy and paste a file, so I select the file in the pane, press "ctrl+c" go to the folder I wanna paste, press "ctrl+v" and nothing happens.
I wanna rename a file, so I select it and press F2 and nothing happens.
I wanna navigate with the file over the file tree, so I select any file and I press "Arrow down key" and nothing happens, the arrow pressing makes the line cursor go down instead of selecting the file below the one I've have selected
I could go on, but you get it.

Actual Behavior

Should be able to paste the file I've just copy in the clipbard.
Should be able to rename the file.
Should be able to navigate.
Should be... but I'm not haha.

Versions

Atom: 1.18.0
Nuclide: 0.239.0
Client OS: WIndows 10 64 bits
Server OS (optional):

Additional Details

Installed packages (apm ls --installed): ├── aligner@1.2.3 ├── aligner-javascript@1.2.0 ├── aligner-php@1.1.1 ├── aligner-scss@1.3.1 ├── atom-autocomplete-php@0.25.6 ├── atom-beautify@0.30.4 ├── atom-typescript@11.0.6 ├── autoclose-html@0.23.0 ├── autocomplete-ionic2-framework@0.3.2 ├── autocomplete-modules@1.6.10 ├── blame@0.12.0 ├── build@0.68.0 ├── build-gulp@0.11.0 ├── build-npm-apm@0.12.0 ├── busy@0.7.0 ├── busy-signal@1.4.3 ├── docblockr@0.10.5 ├── docker@0.7.0 ├── editorconfig@2.2.2 ├── emmet@2.4.3 ├── git-diff-details@1.4.0 ├── git-history@3.3.0 ├── hey-pane@1.0.0 ├── highlight-selected@0.13.1 ├── hyperclick@0.1.2 ├── intentions@1.1.2 ├── js-hyperclick@1.11.0 ├── language-apache@1.7.0 ├── language-babel@2.67.0 ├── language-blade@0.32.0 ├── language-docker@1.1.8 ├── language-dotenv@1.0.0 ├── language-gitignore@0.3.0 ├── language-graphql@0.9.0 ├── language-htaccess@0.1.1 ├── language-ini@1.19.0 ├── language-ocaml@1.9.5 ├── language-vue@0.23.0 ├── linter@2.2.0 ├── linter-eslint@8.2.1 ├── linter-jsonlint@1.3.0 ├── linter-php@1.3.2 ├── linter-phpmd@1.5.3 ├── linter-sass-lint@1.7.4 ├── linter-tslint@1.7.0 ├── linter-twig@0.4.2 ├── linter-ui-default@1.6.2 ├── livereload@0.4.4 ├── local-history@4.3.0 ├── merge-conflicts@1.4.5 ├── minimap@4.28.3 ├── minimap-cursorline@0.2.0 ├── minimap-find-and-replace@4.5.2 ├── minimap-git-diff@4.3.1 ├── minimap-highlight-selected@4.6.1 ├── minimap-linter@2.0.2 ├── minimap-pigments@0.2.2 ├── minimap-selection@4.4.0 ├── minimap-split-diff@0.3.7 ├── nuclide@0.239.0 ├── nuclide-format-js@0.0.36 ├── open-terminal-here@2.3.1 ├── package-switch@0.5.0 ├── php-cs-fixer@4.1.0 ├── php-debug@0.2.4 ├── php-getters-setters@0.5.5 ├── php-integrator-annotations@1.2.0 ├── php-integrator-autocomplete-plus@1.6.0 ├── php-integrator-base@3.0.1 ├── php-integrator-navigation@1.1.2 ├── php-integrator-refactoring@1.4.0 ├── php-integrator-symbol-viewer@0.6.4 ├── php-twig@4.0.0 ├── pigments@0.39.1 ├── project-manager@3.3.5 ├── quick-query@0.10.2 ├── Remote-FTP@1.1.3 ├── sass-autocompile@0.13.3 ├── sort-lines@0.14.0 ├── split-diff@1.4.3 ├── symbols-list@2.4.1 ├── sync-settings@0.8.2 └── tool-bar@1.1.0

nahuelhds commented 7 years ago

This happened with Nuclide 0.236.0. It makes me want to disable the file tree, moving to Atom folder view. It's quite annoying

nahuelhds commented 7 years ago

I've disabled the Nuclide's tree view going to my ~,atom/config.cson and replacing "tree-view" for "nuclide-file-tree" into the "disabledPackages". That works fine but it's doesn't remain after Atom restart, so I have to do it manually every time. =S

matthewwithanm commented 7 years ago

Hey @nahuelhds! Can you explain (3) a bit more? If you focus the file tree and use the arrow keys, it should change the selected file (at which point you can hit return to open the selected one). As far as I can tell, this is how Atom's tree-view behaves too.

The first two are features we don't support yet. I'm not sure if/when we will, but PRs are welcome!

nahuelhds commented 7 years ago

Hi @matthewwithanm. Point 3:

If you focus the file tree and use the arrow keys, it should change the selected file (at which point you can hit return to open the selected one). As far as I can tell, this is how Atom's tree-view behaves too.

That's exactly what I expect but it doesn't happens on my Atom instance under Windows.

About points 1 and 2 it's a basic feature that every tree view have, so I don't see the reason to not support it. I mean, default's Atom tree view does it, so I think that any user that see it's tree view changed -without knowing that it would happen after installing Nuclide- it should at least contain the same basic features. It's very annoying copying and pasting using the right click and the mouse for it.

I love Nuclide so far, but the tree view, without those points it's just a pretty pane and not a useful tree view, in my opinion.

judewang commented 7 years ago

@matthewwithanm: I do think the same thing as @nahuelhds, trying finding ways to disable Nuclide file tree.

facebookarchive / nuclide