facebookarchive / nuclide

An open IDE for web and native mobile development, built on top of Atom
https://nuclide.io
Other
7.79k stars 682 forks source link

Tree view: files greyed out that shouldn't be #1322

Open derwaldgeist opened 7 years ago

derwaldgeist commented 7 years ago

Issue and Steps to Reproduce

Since some updates, files in the Nuclide tree view are randomly greyed out, without any reason for this. They are definitely not affected by .gitignore or Atom's ignore patterns. This problem is also described by another user as a comment to an issue in the main Atom repo:

https://github.com/atom/atom/issues/4095#issuecomment-332940544

Which files are affected varies over time. It looks like this (screenshot taken from the other repo, but mine behaves exactly like this):

https://i.imgur.com/Nzzk8RX.png

Expected Behavior

Files are only greyed out if they are affected by .gitignore or ignore patterns.

Sometimes, also modified files do not show up as such (yellow), although the Git window shows them as changed. But maybe that's a separate issue.

Actual Behavior

Files are greyed out at random.

Versions

Additional Details

Community Packages (90) /Users/waldgeist/.atom/packages
├── Atom-Syntax-highlighting-for-Sass@0.5.0
├── MagicPython@1.0.12 (disabled)
├── ScssBundle@0.5.0
├── atom-beautify@0.30.5
├── atom-bootstrap3@1.2.12
├── atom-import-js@0.11.0
├── atom-lupa@0.7.43
├── atom-material-syntax@1.0.6
├── atom-material-ui@2.0.4
├── atom-ternjs@0.18.3
├── atom-typescript@11.0.9 (disabled)
├── autoclose-html@0.23.0
├── autocomplete-modules@1.7.2
├── autocomplete-paths@2.11.0 (disabled)
├── autocomplete-sass@0.1.0
├── bottom-dock@0.4.4
├── busy-signal@1.4.3
├── cssbeautify@1.3.0
├── custom-folds@1.9.5
├── docblockr@0.11.0
├── editorconfig@2.2.2
├── es6-javascript@1.0.0
├── file-icons@2.1.12
├── fold-comments@0.6.0
├── fold-functions@0.5.0
├── git-control@0.9.0
├── git-history@3.3.0
├── git-plus@7.9.3
├── git-time-machine@1.5.9
├── gl-light-syntax@3.0.0
├── haskell-grammar@0.4.0
├── highlight-line@0.12.0
├── highlight-selected@0.13.1
├── hyperclick@0.1.5
├── ide-typescript@0.6.1
├── incremental-search@5.2.2
├── intentions@1.1.5
├── javascript-snippets@1.2.1
├── js-hyperclick@1.11.1
├── jsformat@0.9.3
├── jshint@1.8.6 (disabled)
├── jsonlint@1.1.4
├── jump-to-import@3.5.0
├── language-SCSS@0.4.0
├── language-babel@2.75.1
├── language-gradle@0.0.3
├── language-graphql@0.9.0
├── language-ini@1.19.0
├── language-javascript-jsx@0.3.7 (disabled)
├── language-lua@0.9.11
├── language-ocaml@1.9.5
├── language-rust@0.4.12 (disabled)
├── language-spacebars@0.2.2
├── language-swift@0.5.0
├── language-thrift@1.0.2
├── language-typescript-grammars-only@1.6.0
├── linter@2.2.0 (disabled)
├── linter-eslint@8.3.2
├── linter-ui-default@1.6.10
├── markdown-folder@0.5.0
├── markdown-preview-plus
├── merge-conflicts@1.4.5
├── minimal-syntax@0.22.0
├── minimal-syntax-dark@0.12.4
├── nord-atom-syntax@0.9.1
├── nord-atom-ui@0.11.0
├── nucleus-dark-ui@0.12.3
├── nuclide@0.259.0
├── nuclide-format-js@0.0.41
├── peacock-syntax@1.4.0
├── peacocks-in-space-syntax@0.7.0
├── pigments@0.40.2 (disabled)
├── platformio-ide-terminal@2.7.0
├── project-manager@3.3.5
├── project-view@0.6.2
├── quick-editor@0.4.3 (disabled)
├── react-snippets@0.9.0
├── remember-folds@0.3.0
├── set-syntax@0.4.0
├── snippet-generator@0.3.2
├── sort-lines@0.15.0
├── spacegray-dark-neue-syntax@1.4.2
├── spacegray-dark-neue-ui@1.7.1
├── split-diff@1.5.1
├── ssh-config@0.12.0
├── theme-switch@0.5.0
├── tidy-markdown@3.0.1
├── todo-show@2.1.0
├── tool-bar@1.1.0
└── unity-shader-files@0.3.1
drmathochist commented 7 years ago

Hi, Tom, I have one idea of what it might be, but I need a little more information. Can you open developer tools (cmd-opt-I) and go to the Elements panel. Push cmd-shift-C and then click one of the greyed-out files to highlight its entry in the DOM. If you get a <div> tag, click the <li> tag surrounding it. Then screenshot the DOM panel and the styles panel next to it.

derwaldgeist commented 7 years ago

Sure, thanks for the fast reply!

Here's the tree view:

image

and the corresponding stylesheets below. Seems as if .generated-fully is responsible for the grey-out. This style comes from nuclide-file-tree.less. I am using the Nord Atom UI theme in combination with the One Dark syntax theme, if that helps.

image

drmathochist commented 7 years ago

Okay, I think it is what I thought it might be. Just to check the one last thing (and this is going to seem kind of odd) can you try a grep for "undefined" and compare the files that match to those that get greyed out?

derwaldgeist commented 7 years ago

Yes, you're right. All the files that are greyed-out have undefined as part of their source code.

drmathochist commented 7 years ago

As I thought; there's no real non-cosmetic effect right now, but I've got a fix that should get merged early next week.