Not showing Flow inline errors

cyrieu commented 6 years ago

Issue and Steps to Reproduce

If I open a file with Nuclide by double-clicking on it or using the file finder (CMD + P), Flow does NOT show errors in the editor. However, if I open the file via the diagnostics panel or via Go To Definition, Flow DOES show errors. Apparently these are two different files, and I can open them like so:

Here I open both in split-plane. They are the exact same file, but left side is what I get from file finder and right is what I get from clicking on an error in the Code Diagnostics panel

Expected Behavior

I think they should be 1 file and I should see the errors at all times??

Actual Behavior

The flow-checked file and the actual file seem to behave differently in the Nuclide editor even though they share the same paths

Versions

Atom: 1.22.1
Nuclide: 0.269.0
Client OS: Mac OSX 10.12.6
Server OS (optional):

Additional Details

Installed packages (apm ls --installed): Community Packages (20) /Users/cyrieu/.atom/packages ├── MagicPython@1.0.12 ├── atom-typescript@11.0.10 ├── emmet@2.4.3 ├── file-icons@2.1.14 ├── highlight-selected@0.13.1 ├── language-babel@2.79.0 ├── language-graphql@0.9.0 ├── language-haskell@1.14.3 ├── language-ini@1.19.0 ├── language-lua@0.9.11 ├── language-ocaml@1.9.5 ├── language-rust@0.4.12 ├── language-swift@0.5.0 ├── language-thrift@1.0.2 ├── nuclide@0.269.0 ├── nuclide-format-js@0.0.41 ├── prettier-atom@0.41.0 ├── set-syntax@0.4.0 ├── sort-lines@0.18.0 └── tool-bar@1.1.0

caseybaggz commented 6 years ago

This happens to me, literally every time I upgrade nuclide... 😭

mordaha commented 6 years ago

Any workaround?

mordaha commented 6 years ago

Okay now i got it! )

This is because of symlinks or similar.

For example i have a project in /Users/user/projects/p1/ And i have a symlink to projects dir in /

$ cd /
$ ln -s  /Users/user/projects projects
$ cd /projects/p1
$ atom .

Now Atom works with /projects/p1/file.js, but the flow-server, started by any linter (i tried linter-flow, ide-flow, flow-ide - all with the same issue) is reporting about real file path, e.g. /Users/user/projects/p1/file.js - so atom (or linter or whatever of them) thinks it is a different file, however it is the same.

I can't get where exactly this 'path' issue is occurred (flow, atom, linter, linter-flow) so I don't have an idea where i should post this 'bug' - to atom repo, to flow repo, to liners repos?

May be this will help someone

facebookarchive / nuclide