pelmers
commented
5 years ago actually there is some tests for this function: https://github.com/facebook/nuclide/blob/master/pkg/nuclide-remote-projects/__atom_tests__/RemoteDirectorySearcher-test.js#L43-L52
But I think the issue here is a windows specific bug -- the path expansion is happening locally (so it's getting a Windows path) but the search is remote (so expects / separators)
Issue and Steps to Reproduce
"Nuclide->Working Sets->Find in active" is not working. Screenshot of issue This is remote folder.
Expected Behavior
Nuclide should list files with appropriate content in "Project Find Results" tab.
Actual Behavior
There is always empty result.
Versions
Additional Details
apm ls --installed): C:\Users\Ezh>apm ls --installed Community Packages (35) C:\Users\Ezh.atom\packages ├── atom-beautify@0.33.1 ├── atom-isort@2.6.3 ├── busy-signal@1.4.3 ├── column-select@1.0.1 ├── file-icons@2.1.24 ├── fuzzy-finder-plus@1.4.0 ├── git-plus@8.1.0 ├── git-status@0.3.4 ├── hey-pane@1.1.0 ├── highlight-selected@0.14.0 ├── intentions@1.1.5 ├── language-babel@2.85.0 ├── language-graphql@0.10.1 ├── language-groovy@0.7.0 ├── language-haskell@1.17.8 ├── language-ini@1.20.0 ├── language-jenkinsfile@0.1.1 ├── language-kotlin@0.5.0 ├── language-lua@0.9.11 ├── language-ocaml@1.9.5 ├── language-rust@0.4.12 ├── language-scala@1.1.9 ├── language-swift@0.5.0 ├── language-thrift@1.0.2 ├── linter@2.2.0 (disabled) ├── linter-ui-default@1.7.1 (disabled) ├── MagicPython@1.0.12 ├── nuclide@0.346.0 ├── nuclide-format-js@0.0.47 ├── platformio-ide-terminal@2.8.4 ├── recent-files-fuzzy-finder@0.6.1 ├── set-syntax@0.4.0 ├── sort-lines@0.18.0 ├── tool-bar@1.1.10 └── tree-view-git-status@1.5.2P.S. I didn't find any unit tests related to this function. Should we write them?