search

facebookarchive / nuclide

An open IDE for web and native mobile development, built on top of Atom
https://nuclide.io
Other
7.79k stars 682 forks source link

added show on cursor over for datatip #1626

Open udnaan opened 5 years ago

udnaan commented 5 years ago

This pull request adds datatip on cursor while using keyboard. The setting can be turned on by going into settings.

This is the same pull request

kcaze commented 5 years ago

This doesn't seem right. I put some logging in _startFetching() and confirmed that if this is turned on, it'll try to fetch datatips on every single keystroke.

This feels like it should at least do _startFetchingDebounce() instead of _startFetching()?

facebook-github-bot commented 5 years ago

@udnaan has updated the pull request. Re-import the pull request

udnaan commented 5 years ago

I switched to startFetchingDebounce but in a local test, this doesn't do what it is suppose to do. I will have to stick with the startFetching unless someone has any insights.

udnaan commented 5 years ago

Any timeframe on when this will be in or is there something else needs to be done to the PR?

k-ode commented 5 years ago

I would also like this and would be happy to test and debug any issues that needs to be fixed.