facebookarchive / nuclide

An open IDE for web and native mobile development, built on top of Atom
https://nuclide.io
Other
7.79k stars 682 forks source link

Node debugger: breakpoints not working since updating to latest Nuclide version. #1634

Closed jp-apps closed 5 years ago

jp-apps commented 5 years ago

Issue and Steps to Reproduce

Since updating to latest Nuclide version, every time the Debugger is attached to a node.js --inspect instance and you set a breakpoint on any line you get the following console message by the Node Debugger:

Error processing "setBreakpoints": Invalid parameters: condition: string value expected

When you check the console in the Developer Tools you get the following stack trace:

\~/.atom/packages/nuclide/modules/nuclide-debugger-common/VsDebugSession.js:219 Uncaught (in promise) Error: [{_extensionName}] Error processing "{_requestType}": {_stack}

at send.then.errorResponse (~/.atom/packages/nuclide/modules/nuclide-debugger-common/VsDebugSession.js:219)

at \<anonymous>

at process._tickCallback (internal/process/next_tick.js:188)

send.then.errorResponse @ \~/.atom/packages/nuclide/modules/nuclide-debugger-common/VsDebugSession.js:219

_tickCallback @ internal/process/next_tick.js:188

async function (async)

addUIBreakpoints @ \~/.atom/packages/nuclide/modules/atom-ide-ui/pkg/atom-ide-debugger/lib/vsp/DebugService.js:1214

toggleSourceBreakpoint @ \~/.atom/packages/nuclide/modules/atom-ide-ui/pkg/atom-ide-debugger/lib/vsp/DebugService.js:1258

_handleGutterClick @ \~/.atom/packages/nuclide/modules/atom-ide-ui/pkg/atom-ide-debugger/lib/BreakpointDisplayController.js:373

Was able to solve it by downgrading to the previous version I had which was 0.351.0

Expected Behavior

Not have an error when setting a breakpoint, and have breakpoint working.

Actual Behavior

Error when setting breakpoint, and breakpoint not working.

Versions

Additional Details

LaCocoRoco commented 5 years ago

Thank you my friend! I got the same problem. Local debugging worked with error "setBreakpoints". Remote debugging failed with the "forEach" error. But downgrading on v0.351.0 solved the problem.

ebluestein commented 5 years ago

Thanks for reporting and sorry about that! We'll have a fix in for the next release cut