Symbol search shortcut conflicts with Ubuntu default

[simonwelsh]

In Ubuntu, ctrl-alt-s defaults to collapsing the current window. This takes priority over Nuclide, so the symbol search can't be invoked by default.

Current workaround is to go into Settings > Keyboard > Shortcuts > Windows, select "Toggle shaded state" and hit backspace to disable the setting in Ubuntu. Or change the shortcut in Nuclide settings.

[bolinfest]

This sounds like an Atom issue rather than a Nuclide issue because they are responsible for both shortcuts. Please re-file against them.

Note you can also create custom keybindings for Atom, so I would recommend that for a temporary workaround: https://atom.io/docs/latest/using-atom-basic-customization#customizing-key-bindings.

[simonwelsh]

https://github.com/facebook/nuclide/blob/master/pkg/nuclide/quick-open/keymaps/nuclide-quick-open.cson seems to suggest otherwise.

[bolinfest]

Ah, sorry, I mistakenly assumed you were talking about the built-in symbols view. Reopening.

[jgebhardt]

Maybe we could define a custom keybinding for symbol search on Linux, such as

'.platform-linux atom-workspace':
  'ctrl-alt-y': 'nuclide-quick-open:toggle-symbol-search'

although this will confuse developers who switch platforms (rare, I know 😄)

@simonwelsh do you have suggestions for a good replacement keybinding?

@bolinfest Between the many different platforms nuclide / atom is run on, we are bound to run into more and more of these issues. I wonder if there exists a comprehensive list of system key bindings per OS that can be consulted to minimize conflicts in the future. This Wikipedia article comes pretty close, but doesn't even include Ubuntu.

[mikeosunajr]

With the new omnisearch bound to cmd+t can we give up and avoiding the clashes with the provider specific shortcuts?

[jgebhardt]

I've been thinking about making the shortcuts contextual, i.e. there is a shortcut for every specific search while the search modal is open.