search

facebookarchive / nuclide

An open IDE for web and native mobile development, built on top of Atom
https://nuclide.io
Other
7.79k stars 683 forks source link

Mistake in doc about keybindings #309

Closed viatsko closed 8 years ago

viatsko commented 8 years ago

http://nuclide.io/docs/shortcuts/

"To open a file in Nuclide, hit ⌘-p, which will open a file finder dialog that does fuzzy matching on your input against file paths. This basically acts as an autocomplete for what you type, though it has some tolerance for misspellings."

Suppose that should be ⌘-t (or even Alt + ⌘ + t), because there's no override of Atom's keybinding by default and ⌘-p in pure Atom + Nuclide is showing default file finder dialog not backed up by watchman.

viatsko commented 8 years ago

Or maybe even suggest to assign Cmd+T's file search on Cmd+P to replace Atom's file search to Nuclide's omni search:

'.platform-darwin atom-workspace':
  'cmd-p': 'nuclide-fuzzy-filename-provider:toggle-provider'

And also add information about watchman there

nmote commented 8 years ago

Weird, cmd+P actually works fine for me. CC @jgebhardt

viatsko commented 8 years ago

Is it correct then? (default Cmd+P) It pops up with empty keymap.cson

Or omnisearch one is correct?

nmote commented 8 years ago

I just looked and for Facebook-internal users we override cmd+P to trigger quick-open. We didn't do that for external users, presumably so that we don't mess with existing workflows too much. So the docs should be updated.

dsifford commented 8 years ago

On the topic of keybindings, to your knowledge @nmote , are we going to ever be able to disable all nuclide keybindings in the future (some packages allow this).

I'm having an extremely hard time overriding ctrl-alt-o

edit: not even 2 minutes after posting this did I find that I had a typo in my keymap. Disregard...

JoelMarcey commented 8 years ago

We have a new page of keyboard shortcuts now. I hope that resolves this issue:

http://nuclide.io/docs/editor/keyboard-shortcuts/