Nuclide should check clang version

ghost commented 8 years ago

Issue and Steps to Reproduce

ERROR (pid:29777) nuclide - Error receiving data clang.cindex.LibclangError: /usr/local/lib/libclang.so: undefined symbol: clang_CXXMethod_isPureVirtual. Please ensure that your python bindings are compatible with your libclang.so version.

I checked my libclang version to be 3.3, and there is not symbol clang_CXXMethod_isPureVirtual in the shared library.

I fixed this by installing clang 3.7.

Expected Behavior

be able to navigate code. (C++)

Actual Behavior

Nothing happened, no reference jumping, no linter, nothing.

Versions

Atom: 1.6.2
Nuclide: 0.129.0
Client OS: OS X 10.11.3 and Ubuntu 14.04
Server OS (optional): Ubuntu 14.04
Additional Details
Installed packages (apm ls --installed): (on Ubuntu 14.04) ├── activate-power-mode@0.4.1 ├── atom-beautify@0.29.2 ├── autocomplete-java@1.2.1 ├── git-time-machine@1.4.1 ├── highlight-selected@0.11.2 ├── language-ini@1.16.0 ├── language-thrift@1.0.2 ├── linter@1.11.4 ├── linter-swiftc@2.0.0 ├── minimap@4.21.0 ├── nuclide@0.129.0 ├── pigments@0.26.0 ├── sort-lines@0.14.0 ├── tool-bar@0.4.0 └── vim-mode@0.65.0

zertosh commented 8 years ago

cc: @hansonw

ghost commented 8 years ago

Just updated the subject.

The error was from logs, and the client was not notified by anything.

hansonw commented 8 years ago

Thanks for trying us out! We should definitely do this. In the meantime, I'll at least update the docs to indicate that this is a requirement.

facebookarchive / nuclide