facebookarchive / nuclide

An open IDE for web and native mobile development, built on top of Atom
https://nuclide.io
Other
7.79k stars 682 forks source link

Nuclide fails to show inline Hack msg with Atom 1.7.1 and Nuclide 0.130 #459

Closed ericqianli closed 8 years ago

ericqianli commented 8 years ago

Issue and Steps to Reproduce

I'm using client Nuclide to connect to a remote server, where hhvm is installed. Hack inline errors/warning were correctly showing before on Atom 1.6.2 Nuclide 129. Once I updated to Atom 1.7.1 and Nuclide 130 it stopped working.

Latest Update: I revert Atom to 1.6.2 and everything works again. I suspect there's some incompatibility between Atom 1.7.1 and Nuclide 0.130.

I can repro all time. I don't know how you would repro though. You have to connect to my server I think. If you really need to do that let's discuss in the followup.

To repro on my side:

  1. Kill all node on server, quit Atom on client.
  2. Restart Atom, remote connect to my server code folder.
  3. hh from server terminal, Hack errors do show up.
  4. Nuclide form client doesn't show any Hack. (Flow does show) screen shot 2016-04-16 at 1 12 11 am

Update: I switched to another client machine and Nuclide from that client did show the Hack errors. So I think it's a client side problem. The server is working fine. The problematic client is running on Atom 1.7.1 Nuclide 130 This working client is running on Atom 1.6.2 Nuclide 130 I suspect Atom 1.7.1 has some mystery here :/

screen shot 2016-04-16 at 1 23 33 am

Expected Behavior

Hack errors/warnings should show

Actual Behavior

Hack errors/warnings didn't show

Versions

zertosh commented 8 years ago

cc: @peterhal

ChrisReeves12 commented 8 years ago

I having problems with this as well.

peterhal commented 8 years ago

This was a transient incompatibility between hack and Nuclide. Let me know if you still experience issues.