search

facebookarchive / nuclide

An open IDE for web and native mobile development, built on top of Atom
https://nuclide.io
Other
7.79k stars 682 forks source link

Diagnostics doesn't work with linter-gcc package #980

Open maboelsoud opened 7 years ago

maboelsoud commented 7 years ago

Issue and Steps to Reproduce

Install nuclide and linter-gcc packages. create a new cpp file. Make an intentional syntax error.

Expected Behavior

GCC errors should show up in the diagnostics table.

Actual Behavior

errors don't show up in the diagnostics. They only show up when I enable the Linter package (which is supposed to have duplicate UI, right? how come GCC linter errors only show up in the Linter package only?)

Versions

Additional Details

├── alpenglow-monokai-atom-syntax@0.0.6
├── an-old-hope-syntax@0.5.0
├── atom-beautify@0.29.13
├── atom-ctags@5.0.0
├── atom-dark-fusion-syntax@1.5.1
├── atom-darker-fusion-syntax@1.2.0
├── atom-jade@0.3.0
├── atom-live-server@1.2.5
├── atom-material-syntax@0.4.6
├── atom-material-syntax-light@0.4.5
├── atom-material-ui@1.3.8
├── atom-panda-syntax@0.13.0
├── atom-react-native-autocomplete@0.0.27
├── atom-terminal@0.8.0
├── atom-ternjs@0.16.1
├── atom-typescript@10.1.12
├── autocomplete@0.47.0
├── autocomplete-clang@0.10.0
├── autocomplete-java@1.2.5
├── autocomplete-js-import@1.2.1
├── autocomplete-modules@1.6.7
├── autocomplete-paths@1.0.2
├── autocomplete-python@1.8.19
├── babel-react-syntax@1.2.0
├── build@0.67.0
├── build-gulp@0.11.0
├── busy@0.7.0
├── change-case@0.6.3
├── code-peek@1.4.14
├── color-picker@2.2.3
├── docblockr@0.9.1
├── duotone-dark-syntax@2.0.1
├── eclectic-syntax@0.2.1
├── emmet@2.4.3
├── es6-javascript@1.0.0
├── expand-region@0.2.6
├── file-icons@1.7.25
├── flexible-ui@0.10.5
├── flow-ide@1.2.1
├── genesis-ui@0.5.0
├── git-diff-details@1.4.0
├── haskell-grammar@0.4.0
├── highlight-selected@0.11.2
├── hybrid-next-syntax@0.9.1
├── hydra-syntax-theme@2.0.3
├── hyperclick@0.0.39
├── isotope-light-ui@2.2.6
├── js-hyperclick@1.9.0
├── js-refactor@0.7.3
├── jumpy@3.1.3
├── kyaho-dark-syntax@1.0.0
├── kyaho-syntax@0.3.0
├── language-babel@2.48.5
├── language-gradle@0.0.3
├── language-ini@1.17.0
├── language-javascript-better@1.7.1
├── language-javascript-jsx@0.3.7
├── language-mongodb@0.3.1
├── language-ocaml@1.1.2
├── language-swift@0.5.0
├── language-thrift@1.0.2
├── linter@1.11.18
├── linter-eslint@8.0.0
├── linter-gcc@0.6.15
├── linter-jshint@3.0.1
├── merge-conflicts@1.4.4
├── minimap@4.25.7
├── minimap-cursorline@0.2.0
├── minimap-find-and-replace@4.5.1
├── minimap-git-diff@4.3.1
├── minimap-highlight-selected@4.4.0
├── minimap-linter@1.6.0
├── minimap-pigments@0.2.2
├── minimap-selection@4.4.0
├── node-debugger@1.9.1
├── nord-atom-syntax@0.4.0
├── nord-atom-ui@0.9.0
├── northem-atom-syntax@2.0.0
├── northem-atom-ui@2.0.0
├── northem-light-atom-syntax@2.0.0
├── northem-light-atom-ui@2.0.0
├── nucleus-dark-ui@0.10.19
├── nuclide@0.186.0
├── nuclide-format-js@0.0.36
├── null-syntax@0.11.4
├── pigments@0.37.0
├── platformio-ide@1.7.1
├── platformio-ide-terminal@2.2.2
├── polymer-snippets@3.2.1
├── react@0.16.1
├── react-es6-snippets@0.3.0
├── react-native-snippets@0.3.0
├── react-snippets@0.5.0
├── refactor@0.11.2
├── remote-atom@1.3.10
├── run-in-atom@1.0.5
├── save-session
├── smart-tab-name@1.0.5
├── sort-lines@0.14.0
├── terminal-plus@0.14.5
├── text-buffer@8.2.0
├── todo-show@1.8.0
├── tool-bar@1.0.1
├── tool-bar-atom@1.7.0
├── vim-mode@0.65.2
├── vim-mode-plus@0.66.1
└── vim-surround@0.8.1
nmote commented 7 years ago

Yes, this should work. Unfortunately I don't know when we'll have the time to dig into it, but if you have the time we would very much appreciate it. If you find out what's going wrong I'm happy to discuss possible fixes, and feel free to CC me on relevant PRs for a quick review.