search

facebookarchive / osf-builder

osf-builder contains tools to build OSF (Open System Firmware) firmware images, and to keep track of their versioning information.
MIT License
7 stars 2 forks source link

Add support to let PLATFORM add/customize it's own VPD variables #14

Open johnnylinwiwynn opened 3 years ago

johnnylinwiwynn commented 3 years ago

It would be nice if we can let each PLATFORM customize their own VPD variables. Right now Makefile.inc adds internal_versions and firmware_version to VPD variables, for each platform it may want to add more such as fsp_log_enable, coreboot_log_level .,etc. $(VPD_TOOL) -f "$<" -O -i RO_VPD -s internal_versions="cat $(FINAL_CONFIG_OUT)" [ -z "$(VERSION)" ] || $(VPD_TOOL) -f "$<" -i RO_VPD -s firmware_version=$(VERSION)

Maybe running a script provided by the PLATFORM for this VPD customization or by other approaches.

johnnylinwiwynn commented 3 years ago

@jonzhang-fb it's not a priority but should be needed if people are going to use osf-builder.