search

facebookarchive / pfff

Tools for code analysis, visualizations, or style-preserving source transformation.
http://github.com/facebook/pfff/wiki/Main
Other
2.44k stars 205 forks source link

Bad annotation: deprecated #115

Open lovek323 opened 9 years ago

lovek323 commented 9 years ago

I'm trying to run scheck on a PHP codebase but I'm getting Fatal error: exception Failure("Bad annotation: deprecated"). I have tried (very briefly) to debug this myself, but have failed.

I'm not sure if this is referring to an annotation in the PHP code (the code definitely makes use of @deprecated) or whether this is some scheck/codegraph annotation.

Any thoughts on what might be going wrong?

phooji commented 9 years ago

Interesting. Looks like this happens when scheck looks for the @Scheck annotation to see if a particular warning should be silenced, and finds something else instead.

I'm not able to repro this locally. @lovek323 any chance I could convince you to attach a kind-of-minimal repro that causes this to happen for you?

lovek323 commented 9 years ago

@phooji: I have been trying to repro this on a simple case, but haven't yet been able to. I'll let you know if I find a minimal repro.

ghost commented 9 years ago

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

zhaakhi commented 9 years ago

Hello, Here is a file that reproduces this issue:

<?php
// @deprecated: foo
class Foo {}
dennisusdev commented 9 years ago

This is still an issue. I found the same failure running against my PHP repo:

Fatal error: exception Failure("Bad annotation: todo")