Remove GNU make version check

facebookarchive / pfff

Tools for code analysis, visualizations, or style-preserving source transformation.

http://github.com/facebook/pfff/wiki/Main

Other

2.44k stars 204 forks source link

Remove GNU make version check #134

Closed mmcco closed 8 years ago

mmcco commented 8 years ago

Build systems very often (usually?) don't check the make version.

Regardless, the existing check is really brittle. For example, only GNU grep has the --colour flag, and it's available on the BSDs only as ggrep. Even when fixing this, the make version check doesn't work for me on OpenBSD. It's probably easiest just to remove it.

This patch fixes configuration on OpenBSD for me.

Also corrects a typo.

facebook-github-bot commented 8 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented 8 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

aryx commented 8 years ago

Thx