search

facebookarchive / pfff

Tools for code analysis, visualizations, or style-preserving source transformation.
http://github.com/facebook/pfff/wiki/Main
Other
2.44k stars 205 forks source link

Remove `-warn-error +a` in released builds. #139

Closed damiendoligez closed 8 years ago

damiendoligez commented 8 years ago

Don't use -warn-error +a in released source. If you want to be warning-clean, you should activate the flag only in debug/development mode. Here I'm proposing a simple solution that relies on GNUmake features. You might want to do it in the configure script instead.

As it is now, pfff 0.29 breaks on OCaml 4.03.0+beta1 because of this line (and the use of String.capitalize, which is now deprecated).

facebook-github-bot commented 8 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented 8 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!