search

facebookarchive / pfff

Tools for code analysis, visualizations, or style-preserving source transformation.
http://github.com/facebook/pfff/wiki/Main
Other
2.44k stars 204 forks source link

Trying to build on macOS 10.12 #145

Closed smithrb closed 8 years ago

smithrb commented 8 years ago

Receiving the following during make:

File "/Users/razbear/Documents/dev/pfff/lang_nw/parsing/lexer_nw.mll", line 140, characters 15-21: Warning 52: the argument of this constructor should not be matched against a constant pattern; the actual value of the argument could change in the future.

Any ideas?

aryx commented 8 years ago

It's a new warning of a recent version of ocaml probably. It just points out bad practice. You can replace Failure("hd") by Failure(_) and the warning should disappear.

smithrb commented 8 years ago

Thanks - that fixed it. Also had _ascii appends to string conversions...

Clean build finally, looking for examples now.

Thanks!

On Aug 2, 2016, at 9:44 PM, Yoann Padioleau notifications@github.com wrote:

It's a new warning of a recent version of ocaml probably. It just points out bad practice. You can replace Failure("hd") by Failure(_) and the warning should disappear.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/facebook/pfff/issues/145#issuecomment-237107916, or mute the thread https://github.com/notifications/unsubscribe-auth/AGO-tgHxGgjibkgKvi0mGBxUMkAuo0vdks5qb_J1gaJpZM4JbKgL.