Improve variadic parameter parsing

facebookarchive / pfff

Tools for code analysis, visualizations, or style-preserving source transformation.

http://github.com/facebook/pfff/wiki/Main

Other

2.44k stars 204 forks source link

Improve variadic parameter parsing #153

Closed soutaro closed 7 years ago

soutaro commented 7 years ago

PHP 5.6 allows having by-reference variadic parameters.

function foo(&...$params) {
  ...
}

This PR is to parse that syntax.

Reference: https://wiki.php.net/rfc/variadics

Because restricting the position of variadic parameters cannot be done by grammar in ocamlyacc (maybe it is not in LALR(1)), the grammar allows having that anywhere in parameter list. And I add validation in action.