search

facebookarchive / pfff

Tools for code analysis, visualizations, or style-preserving source transformation.
http://github.com/facebook/pfff/wiki/Main
Other
2.44k stars 204 forks source link

Fix ocaml 4.04 compatibility #156

Closed petitchevalroux closed 7 years ago

petitchevalroux commented 7 years ago

As mentionned in #151, there is a compatibilty issue with OCaml 4.04

I'm totally noob to ocaml and c is not my cup of tea (or a really old one) but I take this solution from hhmv (https://github.com/facebook/hhvm/commit/28eefc45ef093c0d81e62375bd7cb22eb6d4b947)

Don't know if it helps or broke everything but it compiles and sgrep works xD

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

aryx commented 7 years ago

Merci petitchevalroux. @phooji can you accept the patch? Seems like I don't have the power to do that anymore.

petitchevalroux commented 7 years ago

@aryx you are welcome, i'm glad to contribute :)

aryx commented 7 years ago

Thx @phooji