search

facebookarchive / php-graph-sdk

The Facebook SDK for PHP provides a native interface to the Graph API and Facebook Login. https://developers.facebook.com/docs/php
Other
3.18k stars 1.96k forks source link

Preserve all information during GraphNode conversion, resolves #700 #1085

Closed foaly-nr1 closed 5 years ago

foaly-nr1 commented 5 years ago

Duplicate of https://github.com/facebook/php-graph-sdk/pull/817.

yguedidi commented 5 years ago

@foaly-nr1 just answered on https://github.com/facebook/php-graph-sdk/pull/817#issuecomment-438944185 what should be the behavior IMO. Your test fail because it doesn't test that behavior while the code does :wink:

foaly-nr1 commented 5 years ago

@yguedidi Should this PR point to facebook:5.x? I can't otherwise update the changelog.

yguedidi commented 5 years ago

@foaly-nr1 yes it should

yguedidi commented 5 years ago

@foaly-nr1 you'll have to rebase it :)

yguedidi commented 5 years ago

Closed in favor of #1034