Hack Incompatibility

[justinwray]

The current 5.x and master branches are incompatible with Hack. Within release 5.6.1 the incompatibility stems from two distinct issues:

• The Collection class had a namespace conflict with Hack's HH\Collection (https://docs.hhvm.com/hack/reference/interface/HH.Collection/).

• The parse_str() PHP function is disabled by default in Hack due to security concerns. Furthermore, PHP is deprecating the function in PHP 7.2+.

Is there interest in maintaining compatibility with Hack and PHP within this project, or would it be preferable for the Hack fork to be published on Packagist separately.

[SammyK]

Thanks for raising this issue @justinwray! I think the Facebook PHP SDK should certainly be compatible with Hack since it's an official Facebook project after all. :)

@yguedidi What are your thoughts about maintaining compatibility with Hack vs doing a fork of a 100% Facebook Hack SDK? I'm thinking just making sure the existing one is compatible, but I'm curious of your thoughts. :)

[yguedidi]

@SammyK I'd agree that as a Facebook project, the SDK should by compatible with Hack. The issue is that Travis cannot run tests on latest HHVM version, see below https://github.com/facebook/php-graph-sdk/blob/1f889b4ea9a739963ab78a81a3616ad0374ae3ad/.travis.yml#L23