Fix minimum deployment target for iOS framework

facebookarchive / pop

An extensible iOS and OS X animation library, useful for physics-based interactions.

Other

19.66k stars 2.88k forks source link

Fix minimum deployment target for iOS framework #266

Closed jflinter closed 9 years ago

jflinter commented 9 years ago

Currently the minimum deployment target is set to 6.0 for the pop-ios-framework target. This will generate a warning and cause App Store validation to fail. This sets the minimum deployment target for that target to 8.0 (the minimum required target for cocoa touch frameworks submitted to the app store).

lhecker commented 9 years ago

@jflinter Are you sure that this actually correct? I'm currently developing an app whose IPHONEOS_DEPLOYMENT_TARGET is 7.1 and submitting to the App Store works just fine. ô_O

The only restriction I can find is that the SDK Version must be atleast 8.0: https://developer.apple.com/news/?id=04082015a

grp commented 9 years ago

It's only true for dynamic frameworks, not static libraries.

grp commented 9 years ago

Thanks @jflinter!

jflinter commented 9 years ago

No problem, thanks for merging @grp! Any chance you could push a new git tag so that we can point to that instead of a commit SHA?