Don't use non-standard nested #defines

facebookarchive / pop

An extensible iOS and OS X animation library, useful for physics-based interactions.

Other

19.66k stars 2.88k forks source link

Don't use non-standard nested #defines #317

Closed ericniebler closed 8 years ago

ericniebler commented 8 years ago

Recent clang builds issue a warning on #define FOO defined(BAR), and if the user specified -Werror then this is a hard error. GCC only issues a diagnostic for this with -pedantic, but clang is getting more aggressive about reporting this.

ericniebler commented 8 years ago

I'm a facebook employee. I tried to fill out the CLA, but it told me my email address was already registered. ???

richardjrossiii commented 8 years ago

This change looks good to me. Passing off to @nlutsenko for sign-off and merge...

nlutsenko commented 8 years ago

Lgtm. Nice catch.