facebookarchive / pop

An extensible iOS and OS X animation library, useful for physics-based interactions.
Other
19.66k stars 2.88k forks source link

Facebook-pop animation paused when UITableView scrolling #322

Closed IvanChan closed 8 years ago

IvanChan commented 8 years ago

Facebook pop is NOT friendly with a scrolling tableview? My Facebook-pop animation paused when UITableView scrolling.

A pop animation will pause when tableView is scrolling, I thought the problem is the runloop mode for the displayLink? but the source code seems the the displayLink already added to common modes?

Any one ran into similar circumstance ? How to fix that? (I don't want to change the source code only for my project use in case leading to some other bugs)

kimon commented 8 years ago

Report appreciated. If you could, please attach a sample app that demonstrates the issue - it will help speedup, the investigation. On Sun, Jun 19, 2016 at 8:03 AM _ivanC notifications@github.com wrote:

Facebook pop is NOT friendly with a scrolling tableview? My Facebook-pop animation paused when UITableView scrolling.

A pop animation will pause when tableView is scrolling, I thought the problem is the runloop mode for the displayLink? but the source code seems the the displayLink already added to common modes?

Any one ran into similar circumstance ? How to fix that? (I don't want to change the source code only for my project use in case leading to some other bugs)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/facebook/pop/issues/322, or mute the thread https://github.com/notifications/unsubscribe/AAKD1SwT3_oav7d8_CYLKnexFRM4KP3dks5qNVpTgaJpZM4I5LtI .

IvanChan commented 8 years ago

I just present my animation in main thread normally, @kimon you means that I should call pop_addAnimation in None-main thread?

I try API below to change modes, and it doesn't work.

IvanChan commented 8 years ago

Sorry for my stupid logic code. I just keep calling this method to add a animation.