search

facebookarchive / pop

An extensible iOS and OS X animation library, useful for physics-based interactions.
Other
19.66k stars 2.88k forks source link

Parameter 'The' not found in the function declaration #363

Closed zeusent closed 7 years ago

zeusent commented 7 years ago

This is not a big problem but a problem nevertheless. As you can see in the screenshot bellow, Xcode 8.3.2 is throwing a warning when compiling the latest version of pop. It would be really nice if this could be fixed so that the warning goes away. This happens in POPAnimation.h.

screen shot 2017-05-08 at 17 20 57
albinekcom commented 7 years ago

It is already fixed (check this commit: https://github.com/facebook/pop/commit/92b2c5b7bcad64f7507da34f921492c71ff1d330) but pop.podspec needs to be also updated. (Probably you use this library via CocoaPods.)

zeusent commented 7 years ago

Wow! 9 months ago? Why isnt the Podspec up to date then? :(

albinekcom commented 7 years ago

¯_(ツ)_/¯ I think that the best solution so far is to make this change in your Podfile: pod 'pop', git: 'https://github.com/facebook/pop.git'

zeusent commented 7 years ago

Unfortunately I am using it as a dependency of another Pod :(

Thanks for your help though! I appreciate it!

tirrorex commented 7 years ago

@albinekcom the best solution is for the maintainer of the repo to update the pod spec... @b3ll could we have an update please?

b3ll commented 7 years ago

Oops, sorry I thought I bumped the pod spec, but I accidentally forgot to actually commit the spec bumping part. I'll fix that right now

b3ll commented 7 years ago

Fixed! 94652b53577163c65a2b24e98ee83bbd1b6e638c

tirrorex commented 7 years ago

Thanks mate !

zeusent commented 7 years ago

Somehow I still get the 1.0.9 version :| Was this pushed into the main Cocoapods repo?

b3ll commented 7 years ago

oh I'm sorry, I forgot to update the repo (I'm still new to maintaining pods 😅). Will do so now

b3ll commented 7 years ago

All done!

ChaosPredictor commented 6 years ago

Got something similar on Xcode 9 beta6, pod 1.3.1. Is it the same?

sceen

pod 'pop', git: 'https://github.com/facebook/pop.git' Did NOT work for me ):