search

facebookarchive / pop

An extensible iOS and OS X animation library, useful for physics-based interactions.
Other
19.66k stars 2.88k forks source link

Make externs more correct #385

Closed toulouse closed 6 years ago

toulouse commented 6 years ago

POP has nontrivial C++. Global symbols should have proper linkage declared. This is easy enough - just wrap it in extern "C" { ... }.

nlutsenko commented 6 years ago

Just tweaked it slightly to make sure that we don't unnecessarily add extern declaration around ObjC class. Let's see if it passes CI now.

nlutsenko commented 6 years ago

I may have inadvertently screwed up the commit history here. @toulouse, sorry about that, here is a new PR for this: #399.