facebookarchive / pop

An extensible iOS and OS X animation library, useful for physics-based interactions.
Other
19.66k stars 2.88k forks source link

Update function declaration to latest iOS SDK conventions. #403

Closed pablogthuillier closed 6 years ago

pablogthuillier commented 6 years ago

According to latest iOS SDK updates, void parameters in function declarations should be included void.

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

twitterkb commented 6 years ago

now that the contributor has signed the "Contributor License Agreement" and now that "All checks have passed" and now that "This branch has no conflicts with the base branch" … can it be merged by someone with "write access"?

Kaspik commented 6 years ago

Please!

zorn commented 6 years ago

Please more.

nlutsenko commented 6 years ago

Sure!

BenSS commented 5 years ago

@nlutsenko Can we also get the pod spec version bumped so it's included in the latest?