search

facebookarchive / pop

An extensible iOS and OS X animation library, useful for physics-based interactions.
Other
19.66k stars 2.88k forks source link

Carthage issue #416

Closed dzenbot closed 5 years ago

dzenbot commented 5 years ago 
$ swift -version
Apple Swift version 4.2 (swiftlang-1000.0.36 clang-1000.10.44)
Target: x86_64-apple-darwin18.0.0

$ xcode-select -p
/Applications/Xcode-10-beta6.app/Contents/Developer

$ xcodebuild -version
Xcode 10.0
Build version 10L232m

We're trying to update our carthage dependencies using Xcode 10 Beta 6 (10L232m) but we keep hitting the following build error. It doesn't seem it has been reported before:

/carthage/Carthage/Checkouts/pop/pop/POPGeometry.mm:72:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if SCENEKIT_SDK_AVAILABLE
    ^
In file included from /Users/Ignacio/Documents/Slack/development/ios/slack-objc/carthage/Carthage/Checkouts/pop/pop/POPGeometry.mm:70:
/Users/Ignacio/Documents/Slack/development/ios/slack-objc/carthage/Carthage/Checkouts/pop/pop/POPDefines.h:32:34: note: expanded from macro 'SCENEKIT_SDK_AVAILABLE'
  #define SCENEKIT_SDK_AVAILABLE defined(POP_USE_SCENEKIT)
                                 ^
1 error generated.

** ARCHIVE FAILED **
dzenbot commented 5 years ago

Updating to any commit starting from https://github.com/facebook/pop/pull/317 fixed the issue for us! We've been using a pretty old version.