search

facebookarchive / pop

An extensible iOS and OS X animation library, useful for physics-based interactions.
Other
19.66k stars 2.88k forks source link

add asserts to help catch NAN errors sooner #92

Open kimon opened 10 years ago

kimon commented 10 years ago

add asserts to help catch NAN errors sooner

Notes:

There have been reports of exceptions thrown writing to CA properties. This is most likely developer error, but we should investigate additional POP assertions in hopes of catching sooner. Eg.

0 CoreFoundation exceptionPreprocess 1 libobjc.A.dylib objc_exception_throw 2 CoreFoundation -[NSException initWithCoder:] 3 QuartzCore CA::Layer::set_bounds() 4 QuartzCore CA::Layer::set_bounds() 5 Facebook _staticStates(POPAnimatableProperty.mm:288) 6 Facebook updateAnimatable(POPAnimator.mm:156) 7 Facebook -POPAnimator renderTime: 8 QuartzCore CA::Display::DisplayLinkItem::dispatch() 9 QuartzCore CA::Display::DisplayLink::dispatch_items() 10 IOMobileFramebuffer IOMobileFramebufferVsyncNotifyFunc 11 IOKit IONotificationPortGetRunLoopSource 12 CoreFoundation CFMachPortPerform 13 CoreFoundation CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION 14 CoreFoundation CFRunLoopDoSource1 15 CoreFoundation CFRunLoopRun 16 CoreFoundation CFRunLoopRunSpecific 17 CoreFoundation CFRunLoopRunInMode 18 GraphicsServices GSEventPopRunLoopMode 19 UIKit ImageRefAtPath 20 Facebook main(main.m:25) 21 libdyld.dylib start

ghost commented 9 years ago

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.