Remove Unicode workaround for identifiers

facebookarchive / prepack

A JavaScript bundle optimizer.

http://prepack.io

Other

14.22k stars 424 forks source link

Remove Unicode workaround for identifiers #1020

Open hermanventer opened 7 years ago

hermanventer commented 7 years ago

Babylon's isValidIdentifier test accepts identifiers with unicode characters that are not valid identifiers in some target JavaScript environments. When all such targets have been updated, remove the work around.

See getAsPropertyNameExpression in src/utils/generator.js,

NTillmann commented 6 years ago

Not all target JavaScript environments fully support Unicode yet. Let's wait a bit with this one...