facebookarchive / prepack

A JavaScript bundle optimizer.
http://prepack.io
Other
14.21k stars 424 forks source link

Incompatible with most recent node version? #2520

Closed ghost closed 6 years ago

ghost commented 6 years ago

Installing prepack on a recent node version (I tried v10.9.0 on a 4.18.5-arch1-1-ARCH Linux machine) fails; downgrading my node is, in my case, not an option.

I'm hit with the same error that was brought to our attention by @rpkoller back in June, and am afraid that v8-profiler, the dependency whose installation appears to be the cause of this issue, shows some maintenance issues.

They don't support node > 7 and seem to have had their last release over a year ago. Numerous issues were opened regarding this:

but none of them have been addressed.

Is there anything you can do about this?

hermanventer commented 6 years ago

Is there another profiler with better support?

ghost commented 6 years ago

The v8 profiler in and of itself is fine; it's just the (seemingly unofficial?) node bindings that are causing these issues, i.e. the v8-profiler package.

Is there another profiler with better support?

I would reckon so. I just stumbled upon v8-profiler-node8, which (despite of its name) claims to also support node 10.x.

I tried to install it on my machine, and it built just fine. Maybe you could experiment with substituting the node bindings and see if it also works with your test matrix?

hermanventer commented 6 years ago

Great to hear. If you would like to put a pull request to do the substitution I would be happy to test it locally.

NTillmann commented 6 years ago

Fix has landed.