facebookarchive / prepack

A JavaScript bundle optimizer.
http://prepack.io
Other
14.22k stars 425 forks source link

Investigate ModifiedBindings issue on internal test case #2586

Closed cblappert closed 5 years ago

cblappert commented 5 years ago

Using a large internal test case, it is possible to get to a state where a ModifiedBinding has both its current and previous values undefined. This seems to happen in cases where optimized functions interact with Array nested optimized functions. It may have something to do with either effects not being applied/undone properly or choosing to optimize functions in the global scope.

See TODO added in #2551.

matthargett commented 5 years ago

2596 was merged, so can this be closed now?