search

facebookarchive / prepack

A JavaScript bundle optimizer.
http://prepack.io
Other
14.22k stars 425 forks source link

chore(deps): remove node-zip #2634

Open chyzwar opened 5 years ago

chyzwar commented 5 years ago

node-zip has useful cli but in this case, it makes sense to use jszip directly. I did not use v3 version on jszip because it is only exposing async interface and v2 would hoist better with zip-dir. https://github.com/daraosn/node-zip/blob/master/lib/nodezip.js

I also needed to run yarn upgrade to properly de-duplicate jszip.

chyzwar commented 5 years ago

I pushed some changes to avoid upgrading whole lock files. Hopefully, this would make my change smal enough.

chyzwar commented 5 years ago

I am getting prettier errors in other places. Should I fix these as a part of this PR?