search

facebookarchive / react-360

Create amazing 360 and VR content using React
https://facebook.github.io/react-360
Other
8.73k stars 1.23k forks source link

play videos, forcing the fullscreen on Safari of the iPhone #196

Closed ichengde closed 7 years ago

ichengde commented 7 years ago

Description

Bug: play videos, forcing the fullscreen on Safari of the iPhone

        <VideoPano source={this.state.videoSource} playerState={this.state.playerState} style={this.state.videoPanoStyle}/>

  1. iOs 10.x.x version: It plays videos, forcing the fullscreen on Safari of the iPhone.

  2. iOS 9.x.x version: It can not be used, showing a white screen.

I noticed that GitHub code be updated but React VR code version of npm package is previous. How find a good way to start and debug the latest code in addition to using npm to push a package? I tried to modify package.json using Local Paths in dependencies to build React VR application, but fail in resolve modules.

Is it planned to be compatible with the most non VR equipment?

Expected behavior

It makes videos playable inline on the iPhone (prevents automatic fullscreen). It uses videos as WebGL/ThreeJS textures.

Actual behavior

It plays videos, forcing the fullscreen on Safari of the iPhone.

Reproduction

a minimal example

Additional Information

ichengde commented 7 years ago

maybe use iphone-inline-video in ReactVR/js/Video/VRVideoPlayer.js to resolve this.

larrylin28 commented 7 years ago

1c46c4e will fix this issue on iPhone iOS 10+. If you want to also support iPhone iOS 10-, you may still need to use something like iphone-inline-video. Check https://facebook.github.io/react-vr/docs/video-player.html for how to write a customized video player using 3rd party libraries and hook it into React VR.

larrylin28 commented 7 years ago

I noticed that GitHub code be updated but React VR code version of npm package is previous. How find a good way to start and debug the latest code in addition to using npm to push a package? I tried to modify package.json using Local Paths in dependencies to build React VR application, but fail in resolve modules.

@andrewimm, what would be the best way to test with latest code?

larrylin28 commented 7 years ago

I noticed that GitHub code be updated but React VR code version of npm package is previous. How find a good way to start and debug the latest code in addition to using npm to push a package? I tried to modify package.json using Local Paths in dependencies to build React VR application, but fail in resolve modules.

8681fc1 provides the way to test main build.

ichengde commented 7 years ago

Tnx! I'm using it.

talk about iOS 9.x.x version bug. It can not be used, showing a white screen. It is not the reason for playing the video. It seems to be wrong but the plan may not support iOS 9? _20170518172811

andrewimm commented 7 years ago

Fixed in 1.2.0 release.