Model statement takes Obj and gltf2? Docs state only Obj.

[jgwinner]

Description

Doc and code innacuracy: the code at https://github.com/facebook/react-vr/blob/master/Libraries/Mesh/Model.js and the docs at: https://facebook.github.io/react-vr/docs/model.html

both mention Obj as the supported format.

Down in loaders, we see a reference to GLTF:

react-vr/ReactVR/js/Loaders/GLTF2ModelLoader.js

Issue 320 mentions they are supported and gives an example:

https://github.com/facebook/react-vr/issues/320

Expected behavior

If GLTF is supported, the docs should mention it; probably still catching up, so I'll put this in as a reminder.

Actual behavior

I checked the secondary documentation, and it's in there.

You know, the secondary documentation:

GLTF2ModelLoader.js

:)

[andrewimm]

The code is in master, but it hasn't actually been released into any stable versions yet. We're waiting on v2.0.0 to ship it to the public. It might get confusing if we mentioned GLTF in the docs but no users could actually use it ;)

[jgwinner]

Ah! Got it. That's funny as gltf was mentioned in #320 as a solution to bump maps.

How soon will v2.0.0 be out? I'm writing a book. Maybe I should include gltf in the hopes it'll be out when the book hits. I'll add it 'provisionally' I guess.

Maybe I should upgrade to master just to see ... thoughts?

== John ==

[andrewimm]

glTF shipped in 2.0.0 yesterday, docs update will come soon

[jgwinner]

Yup, cool thanks.

[jgwinner]

Just a gentle reminder, I'm running into an issue and I just checked, the doc's still don't mention gltf2. I'll post the issue separately.

== John ==

[andrewimm]

Docs reflect gltf2 usage now

[jgwinner]

Thank you Andrew!