Dash example failed installing the packages using yarn

nestoralonso commented 7 years ago

Description

Is this a Bug or a Feature Request?

When I tried to install the dependencies of the Dash example from the Examples folder, it fails in the downloadAssets step because the request package is not installed

Expected behavior

That the command yarn succeeds

Actual behavior

It fails to install the dependencies

Reproduction

List all the steps required to encounter the issue you're reporting. These steps should be clear and concise.

An example of your code that reliably reproduces the issue is ideal.

Solution

Add request in devDependencies https://github.com/facebook/react-vr/pull/384

Additional Information

'react-vr' package version: [FILL THIS OUT: get this by running npm list react-vr]
'react-vr-web' package version: [FILL THIS OUT: get this by running npm list react-vr-web]
Operating System: Linux Ubuntu 16.04
Graphics Card: AMD Radeon 7850
Browser: Chrome
VR Device: Daydream

andrewimm commented 7 years ago

Can you please provide a stack trace or error message?

nestoralonso commented 7 years ago

Here is a screenshot of the error when running npm install or yarn in the DashSample folder screenshot from 2017-10-16 21-44-57

In text format

✔ ~/codez/react-vr/Examples/DashSample [master|✔] 
22:17 $ npm i

> dash-sample@ postinstall /home/n/codez/react-vr/Examples/DashSample
> node ./downloadAssets.js

module.js:529
    throw err;
    ^

Error: Cannot find module 'request'
    at Function.Module._resolveFilename (module.js:527:15)
    at Function.Module._load (module.js:476:23)
    at Module.require (module.js:568:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/n/codez/react-vr/Examples/DashSample/downloadAssets.js:3:15)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! dash-sample@ postinstall: `node ./downloadAssets.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the dash-sample@ postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/n/.npm/_logs/2017-10-18T03_17_38_613Z-debug.log

moroneyk commented 6 years ago

Same issue for me screen shot 2017-11-20 at 12 05 46

RadValentin commented 6 years ago

https://github.com/facebook/react-vr/pull/384 added a fix for this, just needs to get merged

facebookarchive / react-360