vertical rotation on mobile, landscape orientation

ghost commented 5 years ago

Description

Is this a Bug or a Feature Request? Bug

Expected behavior

On mobile when in landscape orientation, vertical swiping rotates camera up and down, as it does in portrait orientation.

Actual behavior

Vertical swiping rotates camera left and right.

Reproduction

Generate a new react-360 project, view it on mobile in landscape orientation, and try rotating the camera vertically by swiping up or down.

Solution

Haven't dug deep enough into source code yet, but at first glance looks like DeviceOrientationCameraController accounts for screen orientation when calculating camera rotation while MousePanCameraController does not. That being said, I see methods for touch events in both controllers, and I'm not sure which controller is actually in play in this scenario.

Additional Information

'react-360' package version: react-360@1.0.0
'react-360-web' package version: react-360-web@1.0.2
Operating System: iOS
Browser: All mobile browsers
VR Device: Out of VR

JackPu commented 5 years ago

@dludwick I met the problem. Any solution?

ghost commented 5 years ago

Sorry for the late response - I spent a few hours looking into the camera controllers but wasn't able to come up with a solution. I'm surprised more people haven't run into this issue

facebookarchive / react-360