search

facebookarchive / react-360

Create amazing 360 and VR content using React
https://facebook.github.io/react-360
Other
8.73k stars 1.23k forks source link

One problem in the "getting-started" document #75

Closed yofine closed 7 years ago

yofine commented 7 years ago

Description

I found a small issue when I read the getting-started. The “Running the Samples“ paragraph didn’t say where React VR Prerelease came from. Later, I found the answer from Github README.md which is download the React VR Prerelease.zip from Oculus. I think other new people may also have such trouble.

Solution

I was going to submit a PR to fix the problem, But I learned from other issues that the documents are generated from md files.

One more thing

I am also a fan of react and webvr, When I found ReactVR, it's amazing. Thanks for creating such a cool thing. I and my friends are translating ReactVR's Chinese documents, hoping to share so cool technology with more people :D

amberroy commented 7 years ago

Agree the link should be in there, we'll add it.

wow I think this is the first translation! thanks for letting us know.

amberroy commented 7 years ago

Adding @larrylin28 my teammate who can read Chinese. :)

yofine commented 7 years ago

Cool, thanks for the response

larrylin28 commented 7 years ago

One thing I'd suggest to change in the translation:

screen shot 2017-03-16 at 3 33 44 pm

Although 骨架 is directly translated from ‘skeleton', but it feel a little odd to me when reading.

yofine commented 7 years ago

@larrylin28 Oh thanks. Sometimes 骨架 is also has this meaning, but the 框架 is indeed more appropriate

yofine commented 7 years ago

@larrylin28 The project has just begun and I will follow up on the technical and grammar review