search

facebookarchive / react-meteor

React rendering for Meteor apps
948 stars 113 forks source link

fixes #48 #73

Closed sarahkevinking closed 9 years ago

sarahkevinking commented 9 years ago

Used suggestion as a work around for the issue

facebook-github-bot commented 9 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented 9 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

sarahkevinking commented 9 years ago

Made one more change

The issue seems to be with renderInPlaceOfNode. The problem with this method is that it is trying to render the React node into the DOM and expecting the node to clear itself when the DOM clears.

However by updating the DOM manually (PrevSibs/NextSibs) after inserting the ReactNode, React no longer properly clears the node from the DOM. Event when calling React. unmountComponentAtNode directly.

froatsnook commented 9 years ago

I'm looking into this component destruction issue. This fix didn't do it for me. I'm getting errors like:

Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

Did you make any progress on this in the past few weeks?