search

facebookarchive / react-meteor

React rendering for Meteor apps
948 stars 113 forks source link

reduce rendering with shouldComponentUpdate #78

Closed mikowals closed 9 years ago

mikowals commented 9 years ago

Very handy package and example. Thanks.

Stopping unnecessary renders is more like the current Blaze / Tracker behaviour though I understand it is less important for React since it diffs the virtual DOM. But I thought it would be good for others that transition from Blaze to React by using this leaderboard example to see that shouldComponentUpdate() is available.

facebook-github-bot commented 9 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented 9 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

benjamn commented 9 years ago

Great to have an example of shouldComponentUpdate, even if the performance improvement is not enormous.