search

facebookarchive / react-native-custom-components

Breaking apart the Libraries/CustomComponents part of the React Native repo
Other
70 stars 157 forks source link

fix bug of NaN left style #36

Closed enbochen closed 3 years ago

enbochen commented 5 years ago

This PR solves the bug after upgrading to React Native 0.58.0

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

sharplet commented 5 years ago

FWIW, these transitions still appear to work on 0.59.0, but not on the latest version, 0.59.8 (instead of an animation, the new screen just pops in).

SpencerLynn commented 5 years ago

This likely will fix #37

This fix is probably good, but should the styles also be fixed to not directly lead to this issue?