search

facebookarchive / react-native-fbsdk

A React Native wrapper around the Facebook SDKs for Android and iOS. Provides access to Facebook login, sharing, graph requests, app events etc.
https://developers.facebook.com/docs/react-native
Other
2.99k stars 908 forks source link

[Android] ShareDialog callback promise does not start #606

Closed ryomura closed 5 years ago

ryomura commented 5 years ago

🐛 Bug Report

ShareDialog callback promise does not start.

ShareDialog.show({contentType: 'link', contentUrl: 'http://example.com/'}).then(  
  (result) => { console.log(result); },    
  (error) => { console.log(error); }  
);

ShareDialog opens, but logs are not output when share or cancel.

In the Stable version, mCallbackManager is a static variable of mainActivity, but it is an instance variable in FBActivityEventListener of v1.0.0-rc.5.

Is the cause of this problem handled by mCallbackManager?

Environment

react: 16.8.6 react-native: 0.60.3 react-native-fbsdk: v1.0.0-rc.5

henriqueidt commented 5 years ago

Same error here

eran-pinhas commented 5 years ago

MeToo

HelloCore commented 5 years ago

Could you try this fork, it's from this branch.

yarn add https://github.com/HelloCore/react-native-fbsdk.git\#fix/android-callback-manager
vibdheeraj commented 4 years ago

call back is not working