search

facebookarchive / react-native-fbsdk

A React Native wrapper around the Facebook SDKs for Android and iOS. Provides access to Facebook login, sharing, graph requests, app events etc.
https://developers.facebook.com/docs/react-native
Other
2.99k stars 908 forks source link

Fix crash on iOS when passing null values to `setUserData` #626

Closed janicduplessis closed 5 years ago

janicduplessis commented 5 years ago

If any value passed to setUserData is null it causes a crash on iOS. This is because the fbsdk expects nil and not NSNull. To fix it we pass all values through RCTNilIfNull.

Test Plan:

Test that setUserData({email: null}) doesn't crash anymore.

janicduplessis commented 5 years ago

Closing in favor of #628