search

facebookarchive / react-native-fbsdk

A React Native wrapper around the Facebook SDKs for Android and iOS. Provides access to Facebook login, sharing, graph requests, app events etc.
https://developers.facebook.com/docs/react-native
Other
2.99k stars 908 forks source link

Chore/introduce safeExtGet to simplify root project property access #654

Closed tomoima525 closed 4 years ago

tomoima525 commented 4 years ago

As noted on the title, added safeExtGet function seen in many other RN library projects so that we can remove some redundant version check code.

Test Plan:

facebook-github-bot commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

tomoima525 commented 4 years ago

CLA signed

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

janicduplessis commented 4 years ago

Thanks @tomoima525 !