search

facebookarchive / react-native-fbsdk

A React Native wrapper around the Facebook SDKs for Android and iOS. Provides access to Facebook login, sharing, graph requests, app events etc.
https://developers.facebook.com/docs/react-native
Other
2.99k stars 908 forks source link

Keep Facebook SDK at 5.8 #668

Closed Doko-Demo-Doa closed 4 years ago

Doko-Demo-Doa commented 4 years ago

This PR aims to keep Facebook SDK at 5.8.0. Currently if we try to pod install or pod update the project, it will automatically install latest version of FBSDKCoreKit (5.10.0), which leads to issue #667 . By keeping it at exactly 5.8.0, that issue is solved.

Test Plan:

Just use the updated react-native-fbsdk.podspec file, and don't forget to pod update. Tested on RN 0.61.4 and 0.60.1.

facebook-github-bot commented 4 years ago

Hi Doko-Demo-Doa! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

janicduplessis commented 4 years ago

Thanks @Doko-Demo-Doa ! Let's merge this for now to fix it. We can try to figure out how to get it building with the new version later.

mikehardy commented 4 years ago

cross-note (I posted more detail in related issue): upstream SDK master should work now if that's interesting/testable by anyone, and next release (>= 5.11.2) will contain a fix that allows use of current upstream if I understand correctly

mikehardy commented 4 years ago

Hey - @janicduplessis - any plans to move the react-native-fbsdk forward? upstream is on v7.0.0 now and just for giggles I attempted to compile against it, generating 6 different compile errors now. Just curious what the roadmap looks like and if getting current with the upstream ObjC SDK is on it. Android appears to work with v7 set in android/build.gradle ext block, for what it's worth

janicduplessis commented 4 years ago

@mikehardy Thanks for letting me know, I'll try to update.

janicduplessis commented 4 years ago

Released 2.0.0-beta.0 if anyone wants to help test that'd be great. I only use LoginManager in my app.

mikehardy commented 4 years ago

@janicduplessis I only use LoginManager than one graph query in mine so I don't think my testing results will do more than fall in your result's shadow, but I'll give it a try

mikehardy commented 4 years ago

@janicduplessis took a while to conclusively get to it over the weekend, and as mentioned all I'm doing is a sign-in and then a graph request, but those work for me off your @beta tag, with upstream v7 SDKs integrated. Thanks!

janicduplessis commented 4 years ago

Thanks, will draft some release notes and release this. There wasn't many changes it was mostly removed apis.