facebookarchive / react-native-fbsdk

A React Native wrapper around the Facebook SDKs for Android and iOS. Provides access to Facebook login, sharing, graph requests, app events etc.
https://developers.facebook.com/docs/react-native
Other
2.99k stars 908 forks source link

Fix Gradle setup in android folder #670

Closed friederbluemle closed 4 years ago

friederbluemle commented 4 years ago

build.gradle in android/ did not specify the Android Gradle plugin, making it impossible to build or open the folder in isolation.

Note that the plugin is only required when opening the project stand-alone (not when used as a dependency from an app project). Therefore, it has been wrapped in a project == rootProject statement).

In addition to that, several other related issues were present in that folder, all of which have been fixed in this PR:

Fixes #669

Test Plan:

Use Android Studio and open android/. ("Build" ->) "Make Project".

or

  1. Generate Gradle wrapper on command line: gradle wrapper --gradle-version 5.4.1 --distribution-type all
  2. ./gradlew build
janicduplessis commented 4 years ago

Looks good, thanks for cleaning this up!