search

facebookarchive / react-native-fbsdk

A React Native wrapper around the Facebook SDKs for Android and iOS. Provides access to Facebook login, sharing, graph requests, app events etc.
https://developers.facebook.com/docs/react-native
Other
2.99k stars 908 forks source link

Update README.md #731

Closed leotm closed 4 years ago

leotm commented 4 years ago

https://developers.facebook.com/docs/ios/getting-started is confusing for us because:

In the following list, select the appropriate SDK for the language you will use in this app. If your app uses Swift, select SDK: Cocoapods. If your app uses Objective-C, select SDK: FB SDK

None of these are true in our case, but we do want to have SDK: Cocoapods pre-selected.

Further, 1.1 clarifies to only go as far as

  1. Install Cocoapods.

not further to install pod 'FBSDKCoreKit/Swift'.

facebook-github-bot commented 4 years ago

Hi @leotm!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

janicduplessis commented 4 years ago

Thanks! The instruction probably changed since the readme was last updated.